be up and down

1. if a person is up and down, they are sometimes happy and sometimes sad, usually after something very bad has happened to them She's been very up and down since her husband's death.

2. if a situation is up and down, it is sometimes good and successful and sometimes bad and not successful Things are up and down for dairy farmers at the moment.